[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <24e8464a-923d-cd0f-c681-fc6ca3a5ad59@linaro.org>
Date: Mon, 21 Nov 2022 12:20:39 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Ciprian Regus <ciprian.regus@...log.com>, jic23@...nel.org,
krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: add adi,ad5754.yaml
On 18/11/2022 18:24, Ciprian Regus wrote:
> Add devicetree bindings documentation for the AD5754 DAC driver.
>
> Signed-off-by: Ciprian Regus <ciprian.regus@...log.com>
> ---
> changes in v3:
> - added additionalProperties: false to patternProperties
> - dropped status in the example.
> - added different values for adi,output-range-microvolt in the example.
> Negative values cannot be set since that will create a dt_bindings_check error.
> .../bindings/iio/dac/adi,ad5754.yaml | 181 ++++++++++++++++++
> 1 file changed, 181 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5754.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5754.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5754.yaml
> new file mode 100644
> index 000000000000..de0f6fab82b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5754.yaml
> @@ -0,0 +1,181 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5754.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD5754 DAC
> +
> +maintainers:
> + - Ciprian Regus <ciprian.regus@...log.com>
> +
> +description: |
> + Bindings for the AD5754 and other chip variants digital-to-analog
> + converters.
> +
> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD5724_5734_5754.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad5722_5732_5752.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad5724r_5734r_5754r.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD5722R_5732R_5752R.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad5722
> + - adi,ad5732
> + - adi,ad5752
> + - adi,ad5724
> + - adi,ad5734
> + - adi,ad5754
Keep the list sorted.
> + - adi,ad5722r
I would even suggest sorted entirely, so 5722r follows 5722, but I don't
mind some combo-sorting (logical + alphabetical).
> + - adi,ad5732r
> + - adi,ad5752r
> + - adi,ad5724r
> + - adi,ad5734r
> + - adi,ad5754r
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 30000000
> +
> + spi-cpol: true
> +
> + vref-supply:
> + description:
> + The regulator to use as an external reference. If this is not provided,
> + the internal reference will be used for chips that have this feature.
> + The external reference must be 2.5V.
> +
> + clr-gpios:
> + description: DAC output clear GPIO (CLR pin). If specified, it will be set
> + to high during probe, thus allowing the DAC output to be updated.
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> +patternProperties:
> + "^channel@([0-3])$":
No need for ().
> + type: object
> + additionalProperties: false
> + description: Configurations for the DAC channels
> +
> + properties:
> + reg:
> + description: Channel number
> + maxItems: 1
> +
> + adi,output-range-microvolt:
> + description: |
> + Voltage range of a channel as <minimum, maximum>.
> + oneOf:
> + - items:
> + - const: 0
> + - enum: [5000000, 10000000, 10800000]
> + - items:
> + - const: -5000000
> + - const: 5000000
> + - items:
> + - const: -10000000
> + - const: 10000000
> + - items:
> + - const: -10800000
> + - const: 10800000
> +
> + required:
> + - reg
> + - adi,output-range-microvolt
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - adi,ad5722
> + - adi,ad5732
> + - adi,ad5752
> + - adi,ad5722r
> + - adi,ad5732r
> + - adi,ad5752r
> + then:
> + patternProperties:
> + "^channel@([0-3])$":
No need for ().
> + type: object
> + properties:
> + reg:
> + description: Channel number
> + enum: [0, 1]
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - adi,ad5724
> + - adi,ad5734
> + - adi,ad5754
> + - adi,ad5724r
> + - adi,ad5734r
> + - adi,ad5754r
> + then:
> + patternProperties:
> + "^channel@([0-3])$":
No need for ().
> + type: object
> + properties:
> + reg:
> + description: Channel number
> + enum: [0, 1, 2, 3]
> +
Best regards,
Krzysztof
Powered by blists - more mailing lists