linux-kernel - Re: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e84f8d00-616e-14d7-5427-61065c88c015@gmail.com>
Date:   Mon, 21 Nov 2022 13:33:16 +0200
From:   Matti Vaittinen <mazziesaccount@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Lee Jones <lee@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()

Thanks Uwe!

On 11/21/22 12:24, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Matti Vaittinen <mazziesaccount@...il.com>

> ---
>   drivers/mfd/rohm-bd9576.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
> index f37cd4f27aeb..c854ab5bcd80 100644
> --- a/drivers/mfd/rohm-bd9576.c
> +++ b/drivers/mfd/rohm-bd9576.c
> @@ -88,8 +88,7 @@ static struct regmap_irq_chip bd9576_irq_chip = {
>   	.irq_reg_stride = 1,
>   };
>   
> -static int bd957x_i2c_probe(struct i2c_client *i2c,
> -			     const struct i2c_device_id *id)
> +static int bd957x_i2c_probe(struct i2c_client *i2c)
>   {
>   	int ret;
>   	struct regmap *regmap;
> @@ -180,7 +179,7 @@ static struct i2c_driver bd957x_drv = {
>   		.name = "rohm-bd957x",
>   		.of_match_table = bd957x_of_match,
>   	},
> -	.probe = &bd957x_i2c_probe,
> +	.probe_new = &bd957x_i2c_probe,
>   };
>   module_i2c_driver(bd957x_drv);
>   

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~