linux-kernel - RE: [PATCH] PCI/DOE: Remove asynchronous task support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 02:01:32 +0000
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To:     "Weiny, Ira" <ira.weiny@...el.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
CC:     "Weiny, Ira" <ira.weiny@...el.com>,
        Gregory Price <gregory.price@...verge.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        "Li, Ming4" <ming4.li@...el.com>,
        "Verma, Vishal L" <vishal.l.verma@...el.com>,
        Lukas Wunner <lukas@...ner.de>,
        "Schofield, Alison" <alison.schofield@...el.com>,
        "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: RE: [PATCH] PCI/DOE: Remove asynchronous task support

> From: Ira Weiny <ira.weiny@...el.com>
＞　...
> 
> @@ -423,25 +399,13 @@ struct pci_doe_mb
> *pcim_doe_create_mb(struct pci_dev *pdev, u16 cap_offset)
>  	doe_mb->pdev = pdev;
>  	doe_mb->cap_offset = cap_offset;
>  	init_waitqueue_head(&doe_mb->wq);
> +	mutex_init(&doe_mb->exec_lock);

In real world, not sure whether there is a case that pcim_doe_create_mb() is invoked by 
multiple drivers to create multiple DOE mailbox instances? If there is such a case, we may 
need to ensure there is only one DOE mailbox instance for a physical DOE of pdev @cap_offset.

-Qiuxu