linux-kernel - Re: [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <208d4106-97e9-79b7-4077-788cdafa1b16@redhat.com>
Date:   Mon, 21 Nov 2022 13:48:45 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, mike.kravetz@...cle.com
Cc:     songmuchun@...edance.com, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer

On 21.11.22 11:20, Yang Li wrote:
> mm/hugetlb.c:1531:37: warning: Using plain integer as NULL pointer
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3224
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   mm/hugetlb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 222937d512c4..b6c2fc882f21 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1528,7 +1528,7 @@ static void add_hugetlb_folio(struct hstate *h, struct folio *folio,
>   	}
>   
>   	folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
> -	folio_change_private(folio, 0);
> +	folio_change_private(folio, NULL);
>   	/*
>   	 * We have to set HPageVmemmapOptimized again as above
>   	 * folio_change_private(folio, 0) cleared it.

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb