linux-kernel - Re: [PATCH v2 2/2] leds: trigger: pattern: notify usespace if pattern finished

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfgxHo7YEtfrvvC=yGL28v8-tK4f6Y4ZMnqnw=fj5Q1ew@mail.gmail.com>
Date:   Mon, 21 Nov 2022 15:26:08 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Martin Kurbanov <mmkurbanov@...rdevices.ru>
Cc:     Pavel Machek <pavel@....cz>,
        Raphael Teysseyre <rteysseyre@...il.com>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        kernel@...rdevices.ru
Subject: Re: [PATCH v2 2/2] leds: trigger: pattern: notify usespace if pattern finished

On Mon, Nov 21, 2022 at 2:39 PM Martin Kurbanov
<mmkurbanov@...rdevices.ru> wrote:
>
> In the current moment, userspace caller can schedule LED pattern with

a LED pattern

> appropriate parameters, but it doesn't have ability to listen to any
> events indicated pattern finished. This patch implements such an event
> using sysfs node and sysfs_notify_dirent() call.

...

> +Date:          October 2022
> +KernelVersion: 6.1

It can't be. Have you read my previous comments?

...

> +               1 means pattern is running and number 0 are finish or not run.

are finished

...

> +static void pattern_trig_remove_is_running(struct led_classdev *led_cdev)
> +{
> +       struct pattern_trig_data *data = led_get_trigger_data(led_cdev);
> +
> +       sysfs_put(data->is_running_kn);
> +       device_remove_file(led_cdev->dev, &dev_attr_is_running);
> +}

If the file is opened at this time, what would happen during execution
of this function?

-- 
With Best Regards,
Andy Shevchenko