linux-kernel - Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a18f1506-e54e-d55f-b627-26cae554749b@microchip.com>
Date:   Mon, 21 Nov 2022 13:58:20 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <Delphine_CC_Chiu@...ynn.com>, <michael@...le.cc>
CC:     <patrick@...cx.xyz>, <garnermic@...com>, <pratyush@...nel.org>,
        <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im

On 10/7/22 08:21, Delphine CC Chiu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Add support for winbond w25q01jv-im chip.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index ffaa24055259..850f2fd867aa 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -139,6 +139,8 @@ static const struct flash_info winbond_nor_parts[] = {
>         { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
>                 NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>                               SPI_NOR_QUAD_READ) },
> +       { "w25q01jvm", INFO(0xef7021, 0, 64 * 1024, 2048)
> +               PARSE_SFDP },
>  };
> 

Hi!

The flash entry is not really needed as all its features and parameters
are initialized by parsing SFDP, so we can instead use the spi-nor-generic
driver that was introduced by Michael at:
https://lore.kernel.org/linux-mtd/166903807811.85501.6803386075881922742.b4-ty@microchip.com/T/#t

-- 
Cheers,
ta