linux-kernel - Re: [PATCH v4 1/9] iio: adis: add '__adis_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202211212249.FNtG3nKb-lkp@intel.com>
Date:   Mon, 21 Nov 2022 22:35:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ramona Bolboaca <ramona.bolboaca@...log.com>, jic23@...nel.org,
        nuno.sa@...log.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        Ramona Bolboaca <ramona.bolboaca@...log.com>
Subject: Re: [PATCH v4 1/9] iio: adis: add '__adis_enable_irq()'
 implementation

Hi Ramona,

I love your patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.1-rc6 next-20221121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ramona-Bolboaca/Add-__adis_enable_irq/20221121-202938
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20221121122655.48268-2-ramona.bolboaca%40analog.com
patch subject: [PATCH v4 1/9] iio: adis: add '__adis_enable_irq()' implementation
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/bfde6674ecc00eb34c2af77e57fdb57cd6c1cf03
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ramona-Bolboaca/Add-__adis_enable_irq/20221121-202938
        git checkout bfde6674ecc00eb34c2af77e57fdb57cd6c1cf03
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/iio/accel/ drivers/iio/imu/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/iio/imu/adis.c:19:
   include/linux/iio/imu/adis.h: In function 'adis_enable_irq':
   include/linux/iio/imu/adis.h:410:15: error: implicit declaration of function '__adis_enable_irq'; did you mean 'adis_enable_irq'? [-Werror=implicit-function-declaration]
     410 |         ret = __adis_enable_irq(adis);
         |               ^~~~~~~~~~~~~~~~~
         |               adis_enable_irq
   drivers/iio/imu/adis.c: At top level:
>> drivers/iio/imu/adis.c:279:5: warning: no previous prototype for '__adis_enable_irq' [-Wmissing-prototypes]
     279 | int __adis_enable_irq(struct adis *adis, bool enable)
         |     ^~~~~~~~~~~~~~~~~
   drivers/iio/imu/adis.c:279:5: error: conflicting types for '__adis_enable_irq'; have 'int(struct adis *, bool)' {aka 'int(struct adis *, _Bool)'}
   drivers/iio/imu/adis.c:280:1: note: an argument type that has a default promotion cannot match an empty parameter name list declaration
     280 | {
         | ^
   include/linux/iio/imu/adis.h:410:15: note: previous implicit declaration of '__adis_enable_irq' with type 'int()'
     410 |         ret = __adis_enable_irq(adis);
         |               ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/__adis_enable_irq +279 drivers/iio/imu/adis.c

   271	
   272	/**
   273	 * __adis_enable_irq() - Enable or disable data ready IRQ (unlocked)
   274	 * @adis: The adis device
   275	 * @enable: Whether to enable the IRQ
   276	 *
   277	 * Returns 0 on success, negative error code otherwise
   278	 */
 > 279	int __adis_enable_irq(struct adis *adis, bool enable)
   280	{
   281		int ret;
   282		u16 msc;
   283	
   284		if (adis->data->enable_irq)
   285			return adis->data->enable_irq(adis, enable);
   286	
   287		if (adis->data->unmasked_drdy) {
   288			if (enable)
   289				enable_irq(adis->spi->irq);
   290			else
   291				disable_irq(adis->spi->irq);
   292	
   293			return 0;
   294		}
   295	
   296		ret = __adis_read_reg_16(adis, adis->data->msc_ctrl_reg, &msc);
   297		if (ret)
   298			return ret;
   299	
   300		msc |= ADIS_MSC_CTRL_DATA_RDY_POL_HIGH;
   301		msc &= ~ADIS_MSC_CTRL_DATA_RDY_DIO2;
   302		if (enable)
   303			msc |= ADIS_MSC_CTRL_DATA_RDY_EN;
   304		else
   305			msc &= ~ADIS_MSC_CTRL_DATA_RDY_EN;
   306	
   307		return __adis_write_reg_16(adis, adis->data->msc_ctrl_reg, msc);
   308	}
   309	EXPORT_SYMBOL_NS(__adis_enable_irq, IIO_ADISLIB);
   310	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (282844 bytes)