[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <927643d6c2e5f681847fd2023ee2dab371ecba12.camel@redhat.com>
Date: Tue, 22 Nov 2022 15:54:33 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Colin Foster <colin.foster@...advantage.com>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc: Eric Dumazet <edumazet@...gle.com>,
"David S. Miller" <davem@...emloft.net>,
Florian Fainelli <f.fainelli@...il.com>,
Andrew Lunn <andrew@...n.ch>, UNGLinuxDriver@...rochip.com,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Claudiu Manoil <claudiu.manoil@....com>,
Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH v2 net-next 2/3] net: mscc: ocelot: remove unnecessary
exposure of stats structures
On Sat, 2022-11-19 at 15:14 -0800, Colin Foster wrote:
> Since commit 4d1d157fb6a4 ("net: mscc: ocelot: share the common stat
> definitions between all drivers") there is no longer a need to share the
> stats structures to the world. Relocate these definitions to inside
> ocelot_stats.c instead of a global include header.
>
> Signed-off-by: Colin Foster <colin.foster@...advantage.com>
I think it's preferable to keep the moved code verbatim as-is instead
of additionally fixing the checkpatch warning in the same patch.
The mentioned cleanup could be a follow-up patch - togethar with the
trailing empty line removal.
Cheers,
Paolo
Powered by blists - more mailing lists