[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y3zpgRd89Dz/LTPk@smile.fi.intel.com>
Date: Tue, 22 Nov 2022 17:23:45 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Jakob Koschel <jakobkoschel@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mathias Nyman <mathias.nyman@...ux.intel.com>,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Kevin Cernekee <cernekee@...il.com>,
Mathias Nyman <mathias.nyman@...el.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use
On Tue, Nov 15, 2022 at 05:46:28PM +0200, Jani Nikula wrote:
> On Mon, 14 Nov 2022, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > Some of the existing users, and definitely will be new ones, want to
> > count existing nodes in the list. Provide a generic API for that by
> > moving code from i915 to list.h.
>
> I think I'd find list_length() a much more natural name for this.
i915 suggests my variant :-)
> *shrug*
>
> Acked-by: Jani Nikula <jani.nikula@...el.com>
>
> regardless of what you decide to do with name or static inline etc.
Thanks! I will check which one looks and feels better and update for v3.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists