[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3z/sqRZ3A/j8TIv@kroah.com>
Date: Tue, 22 Nov 2022 17:58:26 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Jiri Slaby <jirislaby@...nel.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Vinod Koul <vkoul@...nel.org>, Alex Elder <elder@...nel.org>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-serial@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 12/15] tty: serial: provide devm_uart_add_one_port()
On Tue, Nov 22, 2022 at 11:21:22AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Provide a devres variant of uart_add_one_port() that removes the managed
> port at device detach.
Ick, no, please let's keep devm away from the serial layer like this.
I would need a LOT of justification for why this is needed, not just one
driver that wants to use it, sorry.
Please do not make this part of the series for this driver, but do it
separately, later, if you still want it.
thanks,
greg k-h
Powered by blists - more mailing lists