linux-kernel - Re: [PATCH] kselftest/cgroup: Add cleanup() to test_cpuset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y30wYVzuCGK/0Zxp@slm.duckdns.org>
Date:   Tue, 22 Nov 2022 10:26:09 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Kamalesh Babulal <kamalesh.babulal@...cle.com>
Cc:     Waiman Long <longman@...hat.com>,
        Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Shuah Khan <shuah@...nel.org>,
        Tom Hromatka <tom.hromatka@...cle.com>,
        cgroups@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/cgroup: Add cleanup() to test_cpuset_prs.sh

On Fri, Nov 18, 2022 at 03:43:30PM +0530, Kamalesh Babulal wrote:
> Install a cleanup function using the trap command for signals EXIT,
> SIGINT, SIGQUIT and SIGABRT.  The cleanup function will perform:
> 1. Online the CPUs that were made offline during the test.
> 2. Removing the cgroups created.
> 3. Restoring the original /sys/kernel/debug/sched/verbose value,
>    currently it's left turned on, irrespective of the original
>    configuration value.
> 
> the test performs steps 1 and 2, on the successful runs, but not during
> all of the failed runs.  With the cleanup(), the system will perform all
> three steps during failed/passed test runs.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh.babulal@...cle.com>

Applied cgroup/for-6.2.

Thanks.

-- 
tejun