linux-kernel - Re: [PATCH v6 0/2] soc: ti: k3-socinfo: Add module build support to the k3 socinfo driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ha64iaf6t.fsf@baylibre.com>
Date:   Tue, 22 Nov 2022 12:48:26 -0800
From:   Kevin Hilman <khilman@...libre.com>
To:     Nishanth Menon <nm@...com>, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, nfrayer@...libre.com,
        Santosh Shilimkar <ssantosh@...nel.org>
Cc:     Nishanth Menon <nm@...com>, glaroque@...libre.com
Subject: Re: [PATCH v6 0/2] soc: ti: k3-socinfo: Add module build support to
 the k3 socinfo driver

Hi Nishanth,

Nishanth Menon <nm@...com> writes:

> Hi Nicolas Frayer,
>
> On Thu, 17 Nov 2022 10:54:17 +0100, Nicolas Frayer wrote:
>> In order for the TI K3 SoC info driver to be built as a module, the
>> following changes have been made:
>> - Converted memory allocations to devm and added the remove callback
>> - Added necessary code to build the driver as a module
>> 
>> v2->v3:
>> dropped module conversion part of this series while other driver
>> dependencies on socinfo are worked out.
>> A dependency issue is introduced by changing subsys_initcall()
>> to module_platform_driver(). Some drivers using the socinfo information
>> probe before the socinfo driver itself and it makes their probe fail.
>> 
>> [...]
>
> I have applied the following to branch ti-drivers-soc-next on [1].
> Thank you!

Sorry for the churn here, but I think these need to be reverted.

We've discoverd some more complexities/issues when socinfo is modular,
and I think the socinfo core code needs some work before this can
actually work reliably for all socinfo users.

Basically, I think we need to finish converting all the socinfo users to
modules before we can be sure of all the corner cases when socinfo
itself is a module.

Sorry about this churn, but I think it's better to be a bit conservative
here and revert before this lands in mainline.

Thanks,

Kevin