linux-kernel - Re: [PATCH 2/3] ftrace: export ftrace_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221122170754.7962724c@gandalf.local.home>
Date:   Tue, 22 Nov 2022 17:07:54 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-kernel@...r.kernel.org, mhiramat@...nel.org,
        revest@...omium.org
Subject: Re: [PATCH 2/3] ftrace: export ftrace_free_filter() to modules

On Tue, 22 Nov 2022 16:59:38 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> > + * This can allocate memory which must be freed before @ops can be freed,
> > + * either by remvoing eached filtered addr or by using  
> 
> I love how you cut and pasted two typos four times. ;-)

Besides the "remvoing" and "eached"...

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

But please send a v2.

-- Steve