[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2c42cb1fe1fa4b11ba3c0263d7886b68@AcuMS.aculab.com>
Date: Tue, 22 Nov 2022 22:23:11 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Thomas Gleixner' <tglx@...utronix.de>,
LKML <linux-kernel@...r.kernel.org>
CC: Linus Torvalds <torvalds@...uxfoundation.org>,
Steven Rostedt <rostedt@...dmis.org>,
Anna-Maria Behnsen <anna-maria@...utronix.de>,
"Peter Zijlstra" <peterz@...radead.org>,
Stephen Boyd <sboyd@...nel.org>,
"Guenter Roeck" <linux@...ck-us.net>,
Andrew Morton <akpm@...ux-foundation.org>,
"Julia Lawall" <Julia.Lawall@...ia.fr>,
Arnd Bergmann <arnd@...db.de>,
Viresh Kumar <viresh.kumar@...aro.org>,
Marc Zyngier <maz@...nel.org>,
Marcel Holtmann <marcel@...tmann.org>,
Johan Hedberg <johan.hedberg@...il.com>,
"Luiz Augusto von Dentz" <luiz.dentz@...il.com>,
"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
"Paolo Abeni" <pabeni@...hat.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [patch V2 09/17] timers: Rename del_timer_sync() to
timer_delete_sync()
From: Thomas Gleixner
> Sent: 22 November 2022 17:45
>
> The timer related functions do not have a strict timer_ prefixed namespace
> which is really annoying.
>
> Rename del_timer_sync() to timer_delete_sync() and provide del_timer_sync()
> as a wrapper. Document that del_timer_sync() is not for new code.
To change the colo[u]r of the bikeshed, would it be better to
name the functions timer_start() and timer_stop[_sync]().
And, as I found out for a local driver, adding items to work queues
from timer callbacks really isn't a good idea at all!
The delayed_work functions handle it a lot better.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
Powered by blists - more mailing lists