[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221121195211.57748b1f@kernel.org>
Date: Mon, 21 Nov 2022 19:52:11 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Saeed Mahameed <saeed@...nel.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
Jamie Bainbridge <jamie.bainbridge@...il.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Eric Dumazet <edumazet@...gle.com>,
"David S . Miller" <davem@...emloft.net>,
Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
David Ahern <dsahern@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Chris Down <chris@...isdown.name>,
Stephen Hemminger <stephen@...workplumber.org>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: Fix tcp_syn_flood_action() if
CONFIG_IPV6=n
On Mon, 21 Nov 2022 14:44:19 -0800 Saeed Mahameed wrote:
> there's a macro inet6_rcv_saddr(sk), we can use it instead of directly
> referencing &sk->sk_v6_rcv_saddr, it already handles the case where
> CONFIG_IPV6=n
>
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -6845,7 +6845,7 @@ static bool tcp_syn_flood_action(const struct sock *sk, const char *proto)
> xchg(&queue->synflood_warned, 1) == 0) {
> if (IS_ENABLED(CONFIG_IPV6) && sk->sk_family == AF_INET6) {
> net_info_ratelimited("%s: Possible SYN flooding on port [%pI6c]:%u. %s.\n",
> - proto, &sk->sk_v6_rcv_saddr,
> + proto, inet6_rcv_saddr(sk),
Great, could you post a full patch? I haven't seen v2, now it's almost
Thanksgiving..
Powered by blists - more mailing lists