linux-kernel - Re: Correct syntax error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3yAyQfCQjRlEV7n@debian.me>
Date:   Tue, 22 Nov 2022 14:56:57 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Wang Honghui <honghui.wang@....com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: Correct syntax error

On Tue, Nov 22, 2022 at 11:04:05AM +0800, Wang Honghui wrote:
> printk_ringbuffer.c

Welcome to LKML! If you want to contribute to Linux kernel, please
see Documentation/process/submitting-patches.rst.

> >From 8d1e2b96c62d06bb691802a06501762da606e97e Mon Sep 17 00:00:00 2001
> From: Wang Honghui <honghui.wang@....com>
> Date: Mon, 21 Nov 2022 16:58:00 +0800
> Subject: [PATCH] Correct syntax error.
> 
> Signed-off-by: Wang Honghui <honghui.wang@....com>
> ---
>  kernel/printk/printk_ringbuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/printk/printk_ringbuffer.c b/kernel/printk/printk_ringbuffer.c
> index 2b7b6ddab4f7..2dc4d5a1f1ff 100644
> --- a/kernel/printk/printk_ringbuffer.c
> +++ b/kernel/printk/printk_ringbuffer.c
> @@ -203,7 +203,7 @@
>   *	prb_rec_init_wr(&r, 5);
>   *
>   *	// try to extend, but only if it does not exceed 32 bytes
> - *	if (prb_reserve_in_last(&e, &test_rb, &r, printk_caller_id()), 32) {
> + *	if (prb_reserve_in_last(&e, &test_rb, &r, printk_caller_id(), 32)) {
>   *		snprintf(&r.text_buf[r.info->text_len],
>   *			 r.text_buf_size - r.info->text_len, "hello");
>   *

Your patch is attached, please send it inline using git-send-email(1)
instead. Use also scripts/get_maintainer.pl to determine appropriate
recipient for the patch.

Also, you need to describe about what and (especially important) why you
made the patch. Write it in imperative mood ("Do foo" instead of "This
patch/commit does foo").

Last but not least, build the kernel with your changes, preferably also
cross-compile it.

PS: I send this reply from mutt, which treats text attachments as inline
message body. Other MUAs may handle them differently.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)