linux-kernel - Re: [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221122090833.5nqm52jzoxxxu2sj@pengutronix.de>
Date:   Tue, 22 Nov 2022 10:08:33 +0100
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     ye.xingchen@....com.cn
Cc:     shawnguo@...nel.org, chi.minghao@....com.cn,
        s.hauer@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
        kernel@...gutronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: imx-weim: use
 devm_platform_get_and_ioremap_resource()

Hi Chi,

thanks for your patch.

On 22-11-22, ye.xingchen@....com.cn wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

LGTM, feel free to add my

Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>

> ---
>  drivers/bus/imx-weim.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..2a6b4f676458 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -263,7 +263,6 @@ static int weim_parse_dt(struct platform_device *pdev)
>  static int weim_probe(struct platform_device *pdev)
>  {
>  	struct weim_priv *priv;
> -	struct resource *res;
>  	struct clk *clk;
>  	void __iomem *base;
>  	int ret;
> @@ -273,8 +272,7 @@ static int weim_probe(struct platform_device *pdev)
>  		return -ENOMEM;
> 
>  	/* get the resource */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, res);
> +	base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>  	if (IS_ERR(base))
>  		return PTR_ERR(base);
> 
> -- 
> 2.25.1
> 
>