lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1ff98f52-93e1-d375-47ae-30b74068ea5b@collabora.com> Date: Tue, 22 Nov 2022 10:12:07 +0100 From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com> To: Nícolas F. R. A. Prado <nfraprado@...labora.com>, Chun-Kuang Hu <chunkuang.hu@...nel.org> Cc: kernel@...labora.com, "Nancy . Lin" <nancy.lin@...iatek.com>, Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>, Matthias Brugger <matthias.bgg@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH] drm/mediatek: Clean dangling pointer on bind error path Il 21/11/22 23:37, Nícolas F. R. A. Prado ha scritto: > mtk_drm_bind() can fail, in which case drm_dev_put() is called, > destroying the drm_device object. However a pointer to it was still > being held in the private object, and that pointer would be passed along > to DRM in mtk_drm_sys_prepare() if a suspend were triggered at that > point, resulting in a panic. Clean the pointer when destroying the > object in the error path to prevent this from happening. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com> > Fixes tag please! :-) Cheers, Angelo > --- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 39a42dc8fb85..a21ff1b3258c 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -514,6 +514,7 @@ static int mtk_drm_bind(struct device *dev) > err_deinit: > mtk_drm_kms_deinit(drm); > err_free: > + private->drm = NULL; > drm_dev_put(drm); > return ret; > }
Powered by blists - more mailing lists