linux-kernel - Re: [PATCH -next] Bluetooth: Fix Kconfig warning for BT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee09680a-899c-96c8-778d-0af04d6d59ee@huawei.com>
Date:   Tue, 22 Nov 2022 17:18:10 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Paul Menzel <pmenzel@...gen.mpg.de>
CC:     <marcel@...tmann.org>, <johan.hedberg@...il.com>,
        <luiz.dentz@...il.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <jkosina@...e.cz>, <gregkh@...uxfoundation.org>,
        <linux-bluetooth@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP


On 2022/11/22 17:06, Benjamin Tissoires wrote:
> Hi,
> 
> On Tue, Nov 22, 2022 at 9:37 AM Paul Menzel <pmenzel@...gen.mpg.de> wrote:
>>
>> Dear YueHaibing,
>>
>>
>> Thank you for your patch.
>>
>>
>> Am 22.11.22 um 04:42 schrieb YueHaibing:
>>
>> Maybe use the more specific summary below:
>>
>> Bluetooth: Add HID_SUPPORT dependency for BT_HIDP
>>
>>> commit 25621bcc8976 add HID_SUPPORT, and HID depends on it now.
>>
>> add*s*
>>
>> or
>>
>> Commit 25621bcc8976 ("HID: Kconfig: split HID support and hid-core
>> compilation") introduces the new Kconfig symbol HID_SUPPORT …
>>
>>
>> Kind regards,
>>
>> Paul
>>
>>
>>> Add HID_SUPPORT dependency for BT_HIDP to fix the warning:
>>>
>>> WARNING: unmet direct dependencies detected for HID
>>>    Depends on [n]: HID_SUPPORT [=n]
>>>    Selected by [m]:
>>>    - BT_HIDP [=m] && NET [=y] && BT_BREDR [=y] && INPUT [=m]
>>>
>>> Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>>> ---
> 
> 
> FWIW, a fix is already in -next:
> https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.2/hid-bpf&id=6cc90ccd4f6cfed98e2a3a378debc69f28d57473

OK, thanks for your info.

> 
>  But thanks for the patch nonetheless!
> 
> Cheers,
> Benjamin
> 
>>
>>>   net/bluetooth/hidp/Kconfig | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
>>> index 14100f341f33..6746be07e222 100644
>>> --- a/net/bluetooth/hidp/Kconfig
>>> +++ b/net/bluetooth/hidp/Kconfig
>>> @@ -1,7 +1,7 @@
>>>   # SPDX-License-Identifier: GPL-2.0-only
>>>   config BT_HIDP
>>>       tristate "HIDP protocol support"
>>> -     depends on BT_BREDR && INPUT
>>> +     depends on BT_BREDR && INPUT && HID_SUPPORT
>>>       select HID
>>>       help
>>>         HIDP (Human Interface Device Protocol) is a transport layer
>>
> 
> .
>