linux-kernel - Re: Files in include/trace/events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f8da54c-b442-e4ae-770c-4e9919bb7bfa@suse.cz>
Date:   Tue, 22 Nov 2022 11:23:03 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Chuck Lever <chuck.lever@...cle.com>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-nfs@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Hyeonggon Yoo <42.hyeyoo@...il.com>,
        Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...nel.org>
Subject: Re: Files in include/trace/events

On 11/12/22 13:33, Steven Rostedt wrote:
> On Sat, 12 Nov 2022 07:27:42 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
>> Hi Chuck,
>> 
>> I was just looking over some files in include/trace/events/ and noticed
>> that there's sunrpc_base.h, fs.h and nfs.h that are not event files.
>> 
>> The include/trace/events/ directory should only hold files that are to
>> create events, not headers that hold helper functions.
>> 
>> Can you please move them out of include/trace/events/ as that directory
>> is "special" in the creation of events.
>> 
>> Perhaps we could create a new directory include/linux/trace/ or
>> include/trace/linux/ specific for these types of files?
>> 
> 
> Hi Vlastimil,
> 
> I also noticed that mmflags.h is in that directory too.
> 
> I'd like to keep only headers defining TRACE_EVENT() in that directory,
> as files there have special meaning.

I guess we could move that one to e.g. mm/mmflags.h as it's used also
outside of trace events anyway (mm/debug.c), but it's not something to
expose to general use in include/ But most includes are from proper
include/trace/events/*.h headers so dunno, maybe
include/trace/<something>/mmflags.h would be more appropriate.

> Thanks,
> 
> -- Steve