lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Nov 2022 11:35:28 +0100 From: Emil Renner Berthing <emil.renner.berthing@...onical.com> To: Hal Feng <hal.feng@...rfivetech.com> Cc: Conor Dooley <conor.dooley@...rochip.com>, Conor Dooley <conor@...nel.org>, "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Palmer Dabbelt <palmer@...belt.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Paul Walmsley <paul.walmsley@...ive.com>, Albert Ou <aou@...s.berkeley.edu>, Ben Dooks <ben.dooks@...ive.com>, Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>, Stephen Boyd <sboyd@...nel.org>, Michael Turquette <mturquette@...libre.com>, Philipp Zabel <p.zabel@...gutronix.de>, Linus Walleij <linus.walleij@...aro.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 4/8] dt-bindings: sifive,ccache0: Support StarFive JH7110 SoC On Tue, 22 Nov 2022 at 11:16, Hal Feng <hal.feng@...rfivetech.com> wrote: > > On Tue, 22 Nov 2022 10:01:30 +0000, Conor Dooley wrote: > > On Tue, Nov 22, 2022 at 05:55:57PM +0800, Hal Feng wrote: > > > On Tue, 22 Nov 2022 09:07:26 +0000, Conor Dooley wrote: > > > > On Tue, Nov 22, 2022 at 04:40:23PM +0800, Hal Feng wrote: > > > > > On Fri, 18 Nov 2022 19:39:52 +0800, Conor Dooley wrote: > > > > > > On Fri, Nov 18, 2022 at 11:37:50AM +0000, Conor Dooley wrote: > > > > > > > On Fri, Nov 18, 2022 at 09:17:10AM +0800, Hal Feng wrote: > > > > > > > > From: Emil Renner Berthing <kernel@...il.dk> > > > > > > > > > > > > > > > > This cache controller is also used on the StarFive JH7110 SoC. > > > > > > > > > > > > > > "... and configured identically to that of the FU740"? > > > > > > > Anyways, > > > > > > > Reviewed-by: Conor Dooley <conor.dooley@...rochip.com> > > > > > > > > > > > > Actually, after looking at the next patch - why can you not fall back to > > > > > > the fu740 one since you appear to have the same configuration as it? > > > > > > > > > > Right, I will drop this patch and use "sifive,fu740-c000-ccache" as > > > > > compatible in dts. > > > > > > > > Uh, that's not quite what I was suggesting. Rather than using that one > > > > in isolation, you can do the following in your dt: > > > > "starfive,jh7110-ccache", "sifive,fu740-c000-ccache" > > > > > > > > And then in the driver we need to make no changes - unless down the line > > > > we find some sort of issue that requires special handling etc. There's > > > > no harm in having a "starfive,jh7110-ccache" IMO. > > > > > > Just like what microchip did as blow? > > below > > > > > > > Documentation/devicetree/bindings/riscv/sifive,ccache0.yaml: > > > properties: > > > compatible: > > > oneOf: > > > - items: > > > - enum: > > > - sifive,ccache0 > > > - sifive,fu540-c000-ccache > > > - sifive,fu740-c000-ccache > > > - starfive,jh7110-ccache > > > - const: cache > > > - items: > > > - const: microchip,mpfs-ccache > > > - const: sifive,fu540-c000-ccache > > > - const: cache > > > > No, I don't think this is correct either. You'd do something like: > > > > > - items: > > > - const: starfive,jh7110-ccache > > > - const: sifive,fu740-c000-ccache For the record I don't think the line above should be there. The fu7400-c000 is a specific tapeout and pretending the JH7110 is that tapeout is not right. Especially when there is already the "sifive,ccache0" string for the generic IP. > > > - const: cache > > Yeah, this is what I mean. Thanks. > > Best regards, > Hal > > > > > And then the driver needs no changes. >
Powered by blists - more mailing lists