[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a731e688122d1a6fdb2f7bdbd71d403fa110e9f2.camel@kernel.org>
Date: Tue, 22 Nov 2022 07:20:35 -0500
From: Jeff Layton <jlayton@...nel.org>
To: Joseph Qi <joseph.qi@...ux.alibaba.com>,
Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>
Cc: hch@....de, linux-kernel@...r.kernel.org,
v9fs-developer@...ts.sourceforge.net,
linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
ceph-devel@...r.kernel.org, linux-cifs@...r.kernel.org,
samba-technical@...ts.samba.org, cluster-devel@...hat.com,
linux-nfs@...r.kernel.org, ocfs2-devel@....oracle.com,
devel@...ts.orangefs.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH] filelock: move file locking definitions to separate
header file
On Tue, 2022-11-22 at 09:51 +0800, Joseph Qi wrote:
> Hi,
>
> On 11/21/22 4:59 AM, Jeff Layton wrote:
> > The file locking definitions have lived in fs.h since the dawn of time,
> > but they are only used by a small subset of the source files that
> > include it.
> >
> > Move the file locking definitions to a new header file, and add the
> > appropriate #include directives to the source files that need them. By
> > doing this we trim down fs.h a bit and limit the amount of rebuilding
> > that has to be done when we make changes to the file locking APIs.
> >
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> > ---
> > fs/9p/vfs_file.c | 1 +
> > fs/afs/internal.h | 1 +
> > fs/attr.c | 1 +
> > fs/ceph/locks.c | 1 +
> > fs/cifs/cifsfs.c | 1 +
> > fs/cifs/cifsglob.h | 1 +
> > fs/cifs/cifssmb.c | 1 +
> > fs/cifs/file.c | 1 +
> > fs/cifs/smb2file.c | 1 +
> > fs/dlm/plock.c | 1 +
> > fs/fcntl.c | 1 +
> > fs/file_table.c | 1 +
> > fs/fuse/file.c | 1 +
> > fs/gfs2/file.c | 1 +
> > fs/inode.c | 1 +
> > fs/ksmbd/smb2pdu.c | 1 +
> > fs/ksmbd/vfs.c | 1 +
> > fs/ksmbd/vfs_cache.c | 1 +
> > fs/lockd/clntproc.c | 1 +
> > fs/lockd/netns.h | 1 +
> > fs/locks.c | 1 +
> > fs/namei.c | 1 +
> > fs/nfs/nfs4_fs.h | 1 +
> > fs/nfs_common/grace.c | 1 +
> > fs/nfsd/netns.h | 1 +
> > fs/ocfs2/locks.c | 1 +
> > fs/ocfs2/stack_user.c | 1 +
>
> Seems it misses the related changes in:
> fs/ocfs2/stackglue.c
>
I was able to build ocfs2.ko just fine without any changes to
stackglue.c. What problem do you see here?
Thanks,
--
Jeff Layton <jlayton@...nel.org>
Powered by blists - more mailing lists