[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3zLwj/G/E3kZsJE@smile.fi.intel.com>
Date: Tue, 22 Nov 2022 15:16:50 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Yang Yingliang <yangyingliang@...wei.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
djrscally@...il.com, heikki.krogerus@...ux.intel.com,
sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org,
rafael@...nel.org
Subject: Re: [PATCH v2] device property: fix of node refcount leak in
fwnode_graph_get_next_endpoint()
On Tue, Nov 22, 2022 at 09:12:41PM +0800, Yang Yingliang wrote:
> On 2022/11/22 20:54, Andy Shevchenko wrote:
> > On Tue, Nov 22, 2022 at 08:00:39PM +0800, Yang Yingliang wrote:
...
> > It seems too complicated for the simple fix.
> >
> > As I said, just drop const qualifier and add fwnode_handle_get() in the 'else'
> > branch. This will allow you to drop if (prev) at the end.
>
> fwnode is const, fwnode_handle_get doesn't accept this type.
I'm talking about parent.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists