linux-kernel - Re: next-20221122: tinyconfig: ppc n s390: kernel/printk/printk.c:95:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221122144839.GI4001@paulmck-ThinkPad-P17-Gen-1>
Date:   Tue, 22 Nov 2022 06:48:39 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     John Ogness <john.ogness@...utronix.de>
Cc:     Petr Mladek <pmladek@...e.com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        open list <linux-kernel@...r.kernel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: next-20221122: tinyconfig: ppc n s390:
 kernel/printk/printk.c:95:1: error: type specifier missing, defaults to
 'int'; ISO C99 and later do not support implicit int
 [-Werror,-Wimplicit-int]

On Tue, Nov 22, 2022 at 03:33:16PM +0106, John Ogness wrote:
> Hi Petr,
> 
> On 2022-11-22, Naresh Kamboju <naresh.kamboju@...aro.org> wrote:
> > Today's Linux next 20221122 tag clang-15 tinyconfig builds fails on
> > powerpc and s390 architectures.
> 
> The problem is that CONFIG_SRCU is not selected. This must be selected
> by any modules that requires SRCU. However, printk.c is _always_ built
> into the kernel (even if !CONFIG_PRINTK). The registration of consoles
> and the console list (which uses SRCU) is _always_ built into the
> kernel.
> 
> So should CONFIG_SRCU now always be active?
> 
> @paulmck: Do you have a problem with permanently activating CONFIG_SRCU?

The people wanting it separate back in the day were those wanting very
tiny kernels.  I have not heard from them in a long time, so maybe it
is now OK to just make SRCU unconditional.

							Thanx, Paul