linux-kernel - Re: [PATCH] ASoC: soc-dai: Do not call snd_soc_link_be_hw_params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166920909090.125457.3717205173938547905.b4-ty@kernel.org>
Date:   Wed, 23 Nov 2022 13:11:30 +0000
From:   Mark Brown <broonie@...nel.org>
To:     lgirdwood@...il.com, Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc:     alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: soc-dai: Do not call snd_soc_link_be_hw_params_fixup() twice

On Fri, 4 Nov 2022 16:02:52 +0000, Richard Fitzgerald wrote:
> For a BE link snd_soc_link_be_hw_params_fixup() is called by
> dpcm_be_dai_hw_params() to initialize the params before it passes them
> to __soc_pcm_hw_params(). Then __soc_pcm_hw_params() refines params to
> match the BE codec and passes that to snd_soc_dai_hw_params().
> 
> The second call of snd_soc_link_be_hw_params_fixup() within
> snd_soc_dai_hw_params() was overwriting the refined params with the
> original BE CPU DAI params. This would then lead to various problems,
> for example passing an invalid number of channels to the codec driver
> hw_params(), or enabling more AIF widgets on the codec than are actually
> mapped by TDM slots.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: soc-dai: Do not call snd_soc_link_be_hw_params_fixup() twice
      commit: 3115be55138afb9fb9ae1b4e99378da34bcfd164

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark