linux-kernel - Re: [PATCH linux-next] powerpc/cell/axon_msi: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Nov 2022 13:42:42 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     "zhang.songyi@....com.cn" <zhang.songyi@....com.cn>,
        "arnd@...db.de" <arnd@...db.de>
CC:     "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "npiggin@...il.com" <npiggin@...il.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH linux-next] powerpc/cell/axon_msi: replace
 DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

Hi,

Le 23/11/2022 à 10:06, zhang.songyi@....com.cn a écrit :
> From: zhang songyi <zhang.songyi@....com.cn>
> 
> Fix the following coccicheck warning:
> /arch/powerpc/platforms/cell/axon_msi.c:457:0-23: WARNING:
> fops_msic should be defined with DEFINE_DEBUGFS_ATTRIBUTE

What's the difference between this new patch and the one that is already 
awaiting application here : 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20211222090655.484551-1-deng.changcheng@zte.com.cn/ 
?

The only difference I see it that the already existing patch has a more 
complete description of the change, so unless I'm missing something it 
would be nice to avoid sending the same changes again and again.

Thanks
Christophe



> 
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>   arch/powerpc/platforms/cell/axon_msi.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
> index 5b012abca773..ab080b5022ff 100644
> --- a/arch/powerpc/platforms/cell/axon_msi.c
> +++ b/arch/powerpc/platforms/cell/axon_msi.c
> @@ -454,7 +454,7 @@ static int msic_get(void *data, u64 *val)
>          return 0;
>   }
> 
> -DEFINE_SIMPLE_ATTRIBUTE(fops_msic, msic_get, msic_set, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(fops_msic, msic_get, msic_set, "%llu\n");
> 
>   void axon_msi_debug_setup(struct device_node *dn, struct axon_msic *msic)
>   {
> @@ -475,6 +475,7 @@ void axon_msi_debug_setup(struct device_node *dn, struct axon_msic *msic)
> 
>          snprintf(name, sizeof(name), "msic_%d", of_node_to_nid(dn));
> 
> -       debugfs_create_file(name, 0600, arch_debugfs_dir, msic, &fops_msic);
> +       debugfs_create_file_unsafe(name, 0600, arch_debugfs_dir,
> +                                  msic, &fops_msic);
>   }
>   #endif /* DEBUG */
> --
> 2.15.2