linux-kernel - Re: [PATCH mm-unstable v4 06/10] mm/hugetlb: convert add_hugetlb_page() to folios and add hugetlb_cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0f009af-ad3a-5c9e-d8a1-0952b1378e21@oracle.com>
Date:   Wed, 23 Nov 2022 07:32:58 -0800
From:   Sidhartha Kumar <sidhartha.kumar@...cle.com>
To:     David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Cc:     akpm@...ux-foundation.org, songmuchun@...edance.com,
        mike.kravetz@...cle.com, willy@...radead.org,
        almasrymina@...gle.com, linmiaohe@...wei.com, hughd@...gle.com
Subject: Re: [PATCH mm-unstable v4 06/10] mm/hugetlb: convert
 add_hugetlb_page() to folios and add hugetlb_cma_folio()


On 11/23/22 1:29 AM, David Hildenbrand wrote:
> On 18.11.22 23:19, Sidhartha Kumar wrote:
>> Convert add_hugetlb_page() to take in a folio, also convert
>> hugetlb_cma_page() to take in a folio.
>>
>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
>
> [...]
>
>>   @@ -1525,21 +1525,21 @@ static void add_hugetlb_page(struct hstate 
>> *h, struct page *page,
>>           h->surplus_huge_pages_node[nid]++;
>>       }
>>   -    set_compound_page_dtor(page, HUGETLB_PAGE_DTOR);
>> -    set_page_private(page, 0);
>> +    folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
>> +    folio_change_private(folio, 0);
>>
>
> As raised (CC'ed you), this should be s/0/NULL/

Sure, I'll make this change in my next version.

Thanks,

Sidhartha Kumar