linux-kernel - Re: [PATCH v7 3/7] dt-bindings: arm: nuvoton: Add bindings for NPCM GFXI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7561a0c3-c63b-a3f2-efeb-4bb0f4ad03e4@kernel.org>
Date:   Wed, 23 Nov 2022 16:59:42 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Marvin Lin <milkfafa@...il.com>, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     openbmc@...ts.ozlabs.org, avifishman70@...il.com,
        tmaimon77@...il.com, tali.perry1@...il.com, kwliu@...oton.com,
        kflin@...oton.com
Subject: Re: [PATCH v7 3/7] dt-bindings: arm: nuvoton: Add bindings for NPCM
 GFXI

On 22/11/2022 09:57, Marvin Lin wrote:
> Add dt-bindings document for Graphics Core Information (GFXI) node. It
> is used by NPCM video driver to retrieve Graphics core information.
> 
> Signed-off-by: Marvin Lin <milkfafa@...il.com>
> ---
>  .../bindings/arm/npcm/nuvoton,gfxi.yaml       | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml
> 

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

> diff --git a/Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml b/Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml
> new file mode 100644
> index 000000000000..5b785bda5739
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/npcm/nuvoton,gfxi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Graphics Core Information block in Nuvoton SoCs
> +
> +maintainers:
> +  - Joseph Liu <kwliu@...oton.com>
> +  - Marvin Lin <kflin@...oton.com>
> +
> +description:
> +  The Graphics Core Information (GFXI) are a block of registers in Nuvoton SoCs
> +  that analyzes Graphics core behavior and provides inforomation in registers.

typo: information

> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - nuvoton,npcm750-gfxi
> +          - nuvoton,npcm845-gfxi
> +      - const: syscon
> +      - const: simple-mfd

That's not simple-mfd, you do not have any devices.


Best regards,
Krzysztof