linux-kernel - Re: [PATCH 07/11] blk-throttle: remove incorrect comment for tg_last_low_overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y35mBVQgYgCvmZhz@slm.duckdns.org>
Date:   Wed, 23 Nov 2022 08:27:17 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Kemeng Shi <shikemeng@...wei.com>
Cc:     josef@...icpanda.com, axboe@...nel.dk, cgroups@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/11] blk-throttle: remove incorrect comment for
 tg_last_low_overflow_time

On Wed, Nov 23, 2022 at 02:03:57PM +0800, Kemeng Shi wrote:
> Function tg_last_low_overflow_time is called with intermediate node as
> following:
> throtl_hierarchy_can_downgrade
>   throtl_tg_can_downgrade
>     tg_last_low_overflow_time
> 
> throtl_hierarchy_can_upgrade
>   throtl_tg_can_upgrade
>     tg_last_low_overflow_time
> 
> throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse
> from leaf node to sub-root node and pass traversed intermediate node
> to tg_last_low_overflow_time.
> 
> No such limit could be found from context and implementation of
> tg_last_low_overflow_time, so remove this limit in comment.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...wei.com>

Acked-by: Tejun Heo <tj@...nel.org>

-- 
tejun