linux-kernel - Re: [PATCH v2] ACPI: make remove callback of ACPI driver void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jwY-cH1F3iJzGakzQG7v-ex7_-AC3cm6tUkfTd81_srw@mail.gmail.com>
Date:   Wed, 23 Nov 2022 19:29:17 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Maximilian Luz <luzmaximilian@...il.com>,
        Dawei Li <set_pte_at@...look.com>
Cc:     gregkh@...uxfoundation.org, rafael@...nel.org,
        u.kleine-koenig@...gutronix.de, dvhart@...radead.org,
        andy@...radead.org, lenb@...nel.org, arnd@...db.de,
        peterhuewe@....de, kys@...rosoft.com, kronos.it@...il.com,
        dmitry.torokhov@...il.com, bleung@...omium.org,
        sujith.thomas@...el.com, vithampi@...are.com, lee@...nel.org,
        wim@...ux-watchdog.org, jgross@...e.com, davem@...emloft.net,
        linux-acpi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v2] ACPI: make remove callback of ACPI driver void

On Tue, Nov 15, 2022 at 10:00 PM Maximilian Luz <luzmaximilian@...il.com> wrote:
>
> On 11/13/22 17:26, Dawei Li wrote:
> > For bus-based driver, device removal is implemented as:
> > 1 device_remove()->
> > 2   bus->remove()->
> > 3     driver->remove()
> >
> > Driver core needs no inform from callee(bus driver) about the
> > result of remove callback. In that case, commit fc7a6209d571
> > ("bus: Make remove callback return void") forces bus_type::remove
> > be void-returned.
> >
> > Now we have the situation that both 1 & 2 of calling chain are
> > void-returned, so it does not make much sense for 3(driver->remove)
> > to return non-void to its caller.
> >
> > So the basic idea behind this change is making remove() callback of
> > any bus-based driver to be void-returned.
> >
> > This change, for itself, is for device drivers based on acpi-bus.
> >
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > Acked-by: Lee Jones <lee@...nel.org>
> > Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> > Signed-off-by: Dawei Li <set_pte_at@...look.com>
>
> Reviewed-by: Maximilian Luz <luzmaximilian@...il.com>  # for drivers/platform/surface/*

Applied as 6.2 material, thanks!