linux-kernel - Re: [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221123185346.q6sfeb74ahj3rdcu@revolver>
Date:   Wed, 23 Nov 2022 18:53:54 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Randy Dunlap <rdunlap@...radead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        kernel test robot <lkp@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL
 is set


Thanks Randy.  I'm going to look into doing as Geert requested and avoid
pulling in dependencies, but this is the right thing to do for now.

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>


* Randy Dunlap <rdunlap@...radead.org> [221119 00:51]:
> Prevent a kconfig warning that is caused by TEST_MAPLE_TREE by adding a
> "depends on" clause for TEST_MAPLE_TREE since 'select' does not follow
> any kconfig dependencies.
> 
> WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
>   Depends on [n]: DEBUG_KERNEL [=n]
>   Selected by [y]:
>   - TEST_MAPLE_TREE [=y] && RUNTIME_TESTING_MENU [=y]
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 120b116208a0 ("maple_tree: reorganize testing to restore module testing")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Liam Howlett <liam.howlett@...cle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-mm@...ck.org
> ---
>  lib/Kconfig.debug |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2259,6 +2259,7 @@ config TEST_XARRAY
>  	tristate "Test the XArray code at runtime"
>  
>  config TEST_MAPLE_TREE
> +	depends on DEBUG_KERNEL
>  	select DEBUG_MAPLE_TREE
>  	tristate "Test the Maple Tree code at runtime"
>