linux-kernel - Re: [PATCH 2/6] drm: use new debugfs device-centered functions on DRM core files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211231146.TTR7Hvh3-lkp@intel.com>
Date:   Wed, 23 Nov 2022 11:49:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Maíra Canal <mcanal@...lia.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Oded Gabbay <ogabbay@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        André Almeida <andrealmeid@...lia.com>,
        Emma Anholt <emma@...olt.net>,
        Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
        Maíra Canal <mcanal@...lia.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Wambui Karuga <wambui@...uga.org>,
        Melissa Wen <mwen@...lia.com>
Subject: Re: [PATCH 2/6] drm: use new debugfs device-centered functions on
 DRM core files

Hi Maíra,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm/drm-next linus/master v6.1-rc6 next-20221122]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ma-ra-Canal/Introduce-debugfs-device-centered-functions/20221123-030721
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20221122190314.185015-3-mcanal%40igalia.com
patch subject: [PATCH 2/6] drm: use new debugfs device-centered functions on DRM core files
config: x86_64-rhel-8.3-func
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/90d303b7798f22a8e99b4c86b2dfc6a43f74b678
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ma-ra-Canal/Introduce-debugfs-device-centered-functions/20221123-030721
        git checkout 90d303b7798f22a8e99b4c86b2dfc6a43f74b678
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/drm_gem_vram_helper.c: In function 'drm_vram_mm_debugfs':
>> drivers/gpu/drm/drm_gem_vram_helper.c:961:62: error: 'vmm' undeclared (first use in this function)
     961 |         struct ttm_resource_manager *man = ttm_manager_type(&vmm->bdev, TTM_PL_VRAM);
         |                                                              ^~~
   drivers/gpu/drm/drm_gem_vram_helper.c:961:62: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/drm_gem_vram_helper.c:960:28: warning: unused variable 'dev' [-Wunused-variable]
     960 |         struct drm_device *dev = entry->dev;
         |                            ^~~


vim +/vmm +961 drivers/gpu/drm/drm_gem_vram_helper.c

6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  952  
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  953  /*
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  954   * struct drm_vram_mm
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  955   */
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  956  
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  957  static int drm_vram_mm_debugfs(struct seq_file *m, void *data)
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  958  {
90d303b7798f22 Maíra Canal       2022-11-22  959  	struct drm_debugfs_entry *entry = m->private;
90d303b7798f22 Maíra Canal       2022-11-22 @960  	struct drm_device *dev = entry->dev;
9de59bc201496f Dave Airlie       2020-08-04 @961  	struct ttm_resource_manager *man = ttm_manager_type(&vmm->bdev, TTM_PL_VRAM);
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  962  	struct drm_printer p = drm_seq_file_printer(m);
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  963  
9de59bc201496f Dave Airlie       2020-08-04  964  	ttm_resource_manager_debug(man, &p);
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  965  	return 0;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  966  }
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  967  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (170435 bytes)