linux-kernel - Re: [RFC net-next v2 2/2] bnxt: Use generic HBH removal helper in tx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimobzAyN5gvLrQAhbhS4tL_ARN=Mo_rWRJN9g+D9rkpGw@mail.gmail.com>
Date:   Wed, 23 Nov 2022 12:42:15 -0800
From:   Michael Chan <michael.chan@...adcom.com>
To:     Coco Li <lixiaoyan@...gle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [RFC net-next v2 2/2] bnxt: Use generic HBH removal helper in tx path

On Wed, Nov 23, 2022 at 11:42 AM Michael Chan <michael.chan@...adcom.com> wrote:
>
> On Wed, Nov 23, 2022 at 11:16 AM Coco Li <lixiaoyan@...gle.com> wrote:
> >
> > @@ -13657,6 +13660,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> >                 dev->features &= ~NETIF_F_LRO;
> >         dev->priv_flags |= IFF_UNICAST_FLT;
> >
> > +       netif_set_tso_max_size(dev, GSO_MAX_SIZE);
>
> Our chips can only transmit TSO packets up to 64K bytes, so I think
> this won't work.

I wanted to double check with the hardware team but there's no one in
the office today.  I will confirm early next week.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)