linux-kernel - Re: [PATCH 0/3] iio: adc: stm32: add smart calibration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221123205650.3be4ee4e@jic23-huawei>
Date:   Wed, 23 Nov 2022 20:56:50 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Fabrice Gasnier <fabrice.gasnier@...s.st.com>
Cc:     Olivier Moysan <olivier.moysan@...s.st.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <linux-iio@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] iio: adc: stm32: add smart calibration

On Wed, 23 Nov 2022 12:04:36 +0100
Fabrice Gasnier <fabrice.gasnier@...s.st.com> wrote:

> On 11/15/22 11:31, Olivier Moysan wrote:
> > Refine offset and linear calibration strategy for STM32MP15 and
> > STM32MP13 SoCs:
> > 
> > - offset calibration
> > This calibration depends on factors such as temperature and voltage.
> > As it is not time consuming, it's worth doing it on each ADC
> > start, to get the best accuracy. There is no need to save these data.
> > 
> > - linear calibration
> > This calibration is basically SoC dependent, so it can be done only once.
> > When this calibration has been performed at boot stage, the ADC kernel
> > driver can retrieve the calibration data from the ADC registers.
> > Otherwise, the linear calibration is performed once by the ADC driver.
> > The backup of these data, allows to restore them on successive ADC starts.
> > 
> > Olivier Moysan (3):
> >   iio: adc: stm32-adc: smart calibration support
> >   iio: adc: stm32-adc: improve calibration error log
> >   iio: adc: stm32-adc: add debugfs to read raw calibration result  
> 
> Hi Olivier,
> 
> For the series, you can add my:
> Reviewed-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>

Applied to the togreg branch of iio.git and pushed out as testing to let
0-day have a first look at it.

Thanks,

Jonathan

> 
> Thanks,
> Fabrice
> 
> > 
> >  drivers/iio/adc/stm32-adc-core.h |   1 +
> >  drivers/iio/adc/stm32-adc.c      | 135 ++++++++++++++++++-------------
> >  2 files changed, 78 insertions(+), 58 deletions(-)
> >