linux-kernel - Re: [PATCH v2 5/5] kbuild: check Make version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y36OZVnAZBqxcrBw@bergen.fjasle.eu>
Date:   Wed, 23 Nov 2022 22:19:33 +0100
From:   Nicolas Schier <nicolas@...sle.eu>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v2 5/5] kbuild: check Make version

On Thu 24 Nov 2022 00:18:28 GMT, Masahiro Yamada wrote:
> This is implemented based on test-le. It will work until GNU Make 10
> is released.

... and as long as nobody uses make versions w/ minor version numbers, 
cp. patch 3/5.

Kind regards,
Nicolas

> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
> (no changes since v1)
> 
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 60ce9dcafc72..797fafbc1b45 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -368,6 +368,9 @@ else # !mixed-build
>  
>  include $(srctree)/scripts/Kbuild.include
>  
> +# Check for the minimal Make version
> +$(if $(call test-lt, $(MAKE_VERSION), 3.82), $(error Make $(MAKE_VERSION) is too old))
> +
>  # Read KERNELRELEASE from include/config/kernel.release (if it exists)
>  KERNELRELEASE = $(call read-file, include/config/kernel.release)
>  KERNELVERSION = $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLEVEL),.$(SUBLEVEL)))$(EXTRAVERSION)
> -- 
> 2.34.1

-- 
epost|xmpp: nicolas@...sle.eu          irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)