linux-kernel - Re: [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Nov 2022 14:52:58 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     David Howells <dhowells@...hat.com>
Cc:     Ilya Dryomov <idryomov@...il.com>,
        Dave Wysochanski <dwysocha@...hat.com>,
        Shyam Prasad N <nspmangalore@...il.com>,
        linux-nfs@...r.kernel.org, linux-cifs@...r.kernel.org,
        Dominique Martinet <asmadeus@...ewreck.org>,
        linux-mm@...ck.org, Rohith Surabattula <rohiths.msft@...il.com>,
        v9fs-developer@...ts.sourceforge.net, ceph-devel@...r.kernel.org,
        linux-cachefs@...hat.com, linux-afs@...ts.infradead.org,
        Matthew Wilcox <willy@...radead.org>,
        Steve French <sfrench@...ba.org>,
        linux-fsdevel@...r.kernel.org, Jeff Layton <jlayton@...nel.org>,
        linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when
 folio removed from pagecache

On Wed, Nov 23, 2022 at 2:48 PM David Howells <dhowells@...hat.com> wrote:
>
>   I've also got rid of the bit clearances
> from the network filesystem evict_inode functions as they doesn't seem to
> be necessary.

Well, the patches look superficially cleaner to me, at least. That
"doesn't seem to be necessary" makes me a bit worried, and I'd have
liked to see a more clear-cut "clearing it isn't necessary because X",
but I _assume_ it's not necessary simply because the 'struct
address_space" is released and never re-used.

But making the lifetime of that bit explicit might just be a good idea.

             Linus