linux-kernel - Re: [PATCH v2] ubifs: Fix build errors as symbol undefined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221123072802.GC29978@pengutronix.de>
Date:   Wed, 23 Nov 2022 08:28:02 +0100
From:   Sascha Hauer <s.hauer@...gutronix.de>
To:     Li Hua <hucool.lihua@...wei.com>
Cc:     richard@....at, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, weiyongjun1@...wei.com,
        yusongping@...wei.com
Subject: Re: [PATCH v2] ubifs: Fix build errors as symbol undefined

On Mon, Nov 21, 2022 at 07:18:47PM +0800, Li Hua wrote:
> With CONFIG_UBIFS_FS_AUTHENTICATION not set, the compiler can assume that
> ubifs_node_check_hash() is never true and drops the call to ubifs_bad_hash().
> Is CONFIG_CC_OPTIMIZE_FOR_SIZE enabled this optimization does not happen anymore.
> 
> So When CONFIG_UBIFS_FS and CONFIG_CC_OPTIMIZE_FOR_SIZE is enabled but
> CONFIG_UBIFS_FS_AUTHENTICATION is not set, the build errors is as followd:
>     ERROR: modpost: "ubifs_bad_hash" [fs/ubifs/ubifs.ko] undefined!
> 
> Fix it by add no-op ubifs_bad_hash() for the CONFIG_UBIFS_FS_AUTHENTICATION=n case.
> 
> Fixes: 16a26b20d2af ("ubifs: authentication: Add hashes to index nodes")
> Signed-off-by: Li Hua <hucool.lihua@...wei.com>

Reviewed-by: Sascha Hauer <s.hauer@...gutronix.de>

Sascha

> ---
>  fs/ubifs/ubifs.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h
> index 478bbbb5382f..2f1f31581094 100644
> --- a/fs/ubifs/ubifs.h
> +++ b/fs/ubifs/ubifs.h
> @@ -1623,8 +1623,13 @@ static inline int ubifs_check_hmac(const struct ubifs_info *c,
>  	return crypto_memneq(expected, got, c->hmac_desc_len);
>  }
>  
> +#ifdef CONFIG_UBIFS_FS_AUTHENTICATION
>  void ubifs_bad_hash(const struct ubifs_info *c, const void *node,
>  		    const u8 *hash, int lnum, int offs);
> +#else
> +static inline void ubifs_bad_hash(const struct ubifs_info *c, const void *node,
> +				  const u8 *hash, int lnum, int offs) {};
> +#endif
>  
>  int __ubifs_node_check_hash(const struct ubifs_info *c, const void *buf,
>  			  const u8 *expected);
> -- 
> 2.17.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |