linux-kernel - Re: [PATCH] clk: imx: DRY cleanup of imx_obtain_fixed_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABGWkvp+Z91uAbegJS2Tfk41O7j+JQ18RAmFoK-MSApHRpEBpQ@mail.gmail.com>
Date:   Wed, 23 Nov 2022 08:47:11 +0100
From:   Dario Binacchi <dario.binacchi@...rulasolutions.com>
To:     Abel Vesa <abel.vesa@...aro.org>
Cc:     linux-kernel@...r.kernel.org, michael@...rulasolutions.com,
        Amarula patchwork <linux-amarula@...rulasolutions.com>,
        Abel Vesa <abelvesa@...nel.org>,
        Fabio Estevam <festevam@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: imx: DRY cleanup of imx_obtain_fixed_clock_hw()

Hi Abel,

On Mon, Nov 21, 2022 at 8:19 PM Abel Vesa <abel.vesa@...aro.org> wrote:
>
> On 22-11-13 19:09:44, Dario Binacchi wrote:
> > The imx_obtain_fixed_clock() and imx_obtain_fixed_clock_hw() functions
> > behave pretty similarly, DRY and call one from another.
> >
> > No functional changes intended.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> >
> > ---
> >
> >  drivers/clk/imx/clk.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c
> > index 5582f18dd632..573b1a6ca1dc 100644
> > --- a/drivers/clk/imx/clk.c
> > +++ b/drivers/clk/imx/clk.c
> > @@ -104,9 +104,7 @@ struct clk_hw *imx_obtain_fixed_clock_hw(
> >  {
> >       struct clk *clk;
> >
> > -     clk = imx_obtain_fixed_clock_from_dt(name);
> > -     if (IS_ERR(clk))
> > -             clk = imx_clk_fixed(name, rate);
> > +     clk = imx_obtain_fixed_clock(name, rate);
>
> NACK here. You're switching to a non "clk_hw" based variant that
> should/would be removed in the near future.
>
> In the future, we want the clock providers to not used "clk" based APIs.
>
> Rule is, AFAIR, to use "clk" based APIs in clock consumer drivers only,
> while using "clk_hw" based APIs in clock provider drivers only.
>
> Right now, only the imx5 and vf610 clock provider drivers still use the
> 'clk' based API. Once those are switched to 'clk_hw' based, all the 'clk'
> i.MX specific APIs will be removed for good.

Thanks for your explanations.

Best regards,

Dario

>
> >       return __clk_get_hw(clk);
> >  }
> >
> > --
> > 2.32.0
> >



-- 

Dario Binacchi

Embedded Linux Developer

dario.binacchi@...rulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@...rulasolutions.com

www.amarulasolutions.com