[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20221123010241.14B70C433B5@smtp.kernel.org>
Date: Tue, 22 Nov 2022 17:02:39 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
linux-kernel@...r.kernel.org
Cc: Amarula patchwork <linux-amarula@...rulasolutions.com>,
michael@...rulasolutions.com,
Dario Binacchi <dario.binacchi@...rulasolutions.com>,
kernel test robot <lkp@...el.com>,
Allison Randal <allison@...utok.net>,
Miaoqian Lin <linmq006@...il.com>,
Michael Turquette <mturquette@...libre.com>,
Tero Kristo <kristo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Tony Lindgren <tony@...mide.com>, linux-clk@...r.kernel.org,
linux-omap@...r.kernel.org
Subject: Re: [PATCH v4 2/2] clk: ti: dra7-atl: don't allocate `parent_names' variable
Quoting Dario Binacchi (2022-11-13 10:11:47)
> The `parent_names' variable was freed also in case of kzalloc() error.
> Instead of modifying the code to perform a proper memory release, I
> decided to fix the bug by not allocating memory.
> Since only one parent name is referenced, it is not necessary to
> allocate this variable at runtime and therefore you can avoid calling
> the kzalloc() function. This simplifies the code (even calls to kfree
> can be removed) and improves the performance of the routine.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> Reported-by: kernel test robot <lkp@...el.com>
>
> ---
Applied to clk-next
Powered by blists - more mailing lists