linux-kernel - usb: gadget: f_uac2: Fix incorrect increment of bNumEndpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1669193290-24263-1-git-send-email-quic_prashk@quicinc.com>
Date:   Wed, 23 Nov 2022 14:18:10 +0530
From:   Prashanth K <quic_prashk@...cinc.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Hofman <pavel.hofman@...tera.com>,
        Joe Perches <joe@...ches.com>, Julian Scheel <julian@...st.de>,
        Colin Ian King <colin.i.king@...il.com>
CC:     Pratham Pratap <quic_ppratap@...cinc.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Prashanth K <quic_prashk@...cinc.com>
Subject: usb: gadget: f_uac2: Fix incorrect increment of bNumEndpoints

Currently connect/disconnect of USB cable calls afunc_bind and
eventually increments the bNumEndpoints. And performing multiple
plugin/plugout will incorrectly increment bNumEndpoints on the
next plug-in leading to invalid configuration of descriptor and
hence enumeration failure.

Fix this by resetting the value of bNumEndpoints to 1 on every
afunc_bind call.

Signed-off-by: Pratham Pratap <quic_ppratap@...cinc.com>
Signed-off-by: Prashanth K <quic_prashk@...cinc.com>
---
 drivers/usb/gadget/function/f_uac2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
index 08726e4..0219cd7 100644
--- a/drivers/usb/gadget/function/f_uac2.c
+++ b/drivers/usb/gadget/function/f_uac2.c
@@ -1142,6 +1142,7 @@ afunc_bind(struct usb_configuration *cfg, struct usb_function *fn)
 		}
 		std_as_out_if0_desc.bInterfaceNumber = ret;
 		std_as_out_if1_desc.bInterfaceNumber = ret;
+		std_as_out_if1_desc.bNumEndpoints = 1;
 		uac2->as_out_intf = ret;
 		uac2->as_out_alt = 0;
 
-- 
2.7.4