linux-kernel - [PATCH linux-next] KVM: x86: remove redundant ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Nov 2022 17:04:45 +0800 (CST)
From:   <zhang.songyi@....com.cn>
To:     <seanjc@...gle.com>
Cc:     <pbonzini@...hat.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
        <bp@...en8.de>, <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
        <hpa@...or.com>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <zhang.songyi@....com.cn>
Subject: [PATCH linux-next] KVM: x86: remove redundant ret variable

From: zhang songyi <zhang.songyi@....com.cn>

Return value from apic_get_tmcct() directly instead of taking
this in another redundant variable.

Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
---
 arch/x86/kvm/lapic.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index d7639d126e6c..707970804502 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -1363,7 +1363,6 @@ static u32 apic_get_tmcct(struct kvm_lapic *apic)
 {
        ktime_t remaining, now;
        s64 ns;
-       u32 tmcct;

        ASSERT(apic != NULL);

@@ -1378,10 +1377,9 @@ static u32 apic_get_tmcct(struct kvm_lapic *apic)
                remaining = 0;

        ns = mod_64(ktime_to_ns(remaining), apic->lapic_timer.period);
-       tmcct = div64_u64(ns,
-                        (APIC_BUS_CYCLE_NS * apic->divide_count));

-       return tmcct;
+       return div64_u64(ns,
+                       (APIC_BUS_CYCLE_NS * apic->divide_count));
 }

 static void __report_tpr_access(struct kvm_lapic *apic, bool write)
--
2.15.2