linux-kernel - Re: [PATCH] ACPI: bus: make osc_sb_ffh_opregion_support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221123095421.ffolxbq2csqirw7u@bogus>
Date:   Wed, 23 Nov 2022 09:54:21 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] ACPI: bus: make osc_sb_ffh_opregion_support_confirmed
 static

On Wed, Nov 23, 2022 at 11:42:15AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of bus.c, so marks it static.
> 
> drivers/acpi/bus.c:304:6: warning: symbol 'osc_sb_ffh_opregion_support_confirmed' was not declared. Should it be static?
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3241
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>

Sorry for not replying to the original report which I meant to and for some
reason left it in the draft. Anyways in order to fix another bug, this
variable was removed thereby removing this build/sparse warning. This
warning should not appear from today's linux-next.

Thanks for spotting and this patch fixing it.

-- 
Regards,
Sudeep