lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Nov 2022 11:48:06 +0100 From: Florian Weimer <fweimer@...hat.com> To: "Jason A. Donenfeld" <Jason@...c4.com> Cc: linux-kernel@...r.kernel.org, patches@...ts.linux.dev, tglx@...utronix.de, linux-crypto@...r.kernel.org, x86@...nel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Adhemerval Zanella Netto <adhemerval.zanella@...aro.org>, Carlos O'Donell <carlos@...hat.com> Subject: Re: [PATCH v6 2/3] random: introduce generic vDSO getrandom() implementation * Jason A. Donenfeld: > static void *vgetrandom_alloc(size_t *num, size_t *size_per_each, unsigned int flags) > { > unsigned long ret = syscall(__NR_vgetrandom_alloc, num, size_per_each, flags); > return ret > -4096UL ? NULL : (void *)ret; > } The traditional syscall function returns -1 on error and set errors, so using unsing long and the 4096 is quite misleading. Thanks, Florian
Powered by blists - more mailing lists