[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dcd180f6-7769-3bc5-403f-8960e922bb50@collabora.com>
Date: Wed, 23 Nov 2022 12:55:14 +0100
From: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
To: John Keeping <john@...anate.com>, linux-usb@...r.kernel.org
Cc: Fabien Chouteau <fabien.chouteau@...co.com>,
Peter Korsgaard <peter.korsgaard@...co.com>,
Felipe Balbi <balbi@...com>,
Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Lee Jones <lee@...nel.org>,
Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH 2/3] usb: gadget: f_hid: fix refcount leak on error path
W dniu 22.11.2022 o 13:35, John Keeping pisze:
> When failing to allocate report_desc, opts->refcnt has already been
> incremented so it needs to be decremented to avoid leaving the options
> structure permanently locked.
>
> Fixes: 21a9476a7ba8 ("usb: gadget: hid: add configfs support")
> Signed-off-by: John Keeping <john@...anate.com>
I'd personally place the bugfix before patches 1 and 3, but anyway
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
> ---
> drivers/usb/gadget/function/f_hid.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
> index 8b8bbeaa27cb..6be6009f911e 100644
> --- a/drivers/usb/gadget/function/f_hid.c
> +++ b/drivers/usb/gadget/function/f_hid.c
> @@ -1292,6 +1292,7 @@ static struct usb_function *hidg_alloc(struct usb_function_instance *fi)
> GFP_KERNEL);
> if (!hidg->report_desc) {
> put_device(&hidg->dev);
> + --opts->refcnt;
> mutex_unlock(&opts->lock);
> return ERR_PTR(-ENOMEM);
> }
Powered by blists - more mailing lists