linux-kernel - Re: [PATCH 1/2] serial: atmel: cleanup atmel_start+stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42d51c09-d6e4-52db-ce55-0b827341f080@gmail.com>
Date:   Wed, 23 Nov 2022 13:47:03 +0100
From:   Richard Genoud <richard.genoud@...il.com>
To:     Michael Walle <michael@...le.cc>,
        "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] serial: atmel: cleanup atmel_start+stop_tx()

Le 23/11/2022 à 09:50, Michael Walle a écrit :
> Am 2022-11-23 09:27, schrieb Jiri Slaby (SUSE):
>> Define local variables holding information about whether pdc or dma is
>> used in the HW. These are retested several times by calls to
>> atmel_use_pdc_tx() and atmel_use_dma_tx(). So to make the code more
>> readable, simply cache the values.
>>
>> This is also a preparatory patch for the next one (where is_pdc is used
>> once more in atmel_stop_tx()).
>>
>> Cc: Richard Genoud <richard.genoud@...il.com>
>> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
>> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
>> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Reported-by: Michael Walle <michael@...le.cc>
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> 
> Already merged, but:
> Tested-by: Michael Walle <michael@...le.cc>
Acked-by: Richard Genoud <richard.genoud@...il.com>
> 
> Thanks,
> -michael
Thanks !