[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221123130500.1030189-8-gsomlo@gmail.com>
Date: Wed, 23 Nov 2022 08:04:53 -0500
From: Gabriel Somlo <gsomlo@...il.com>
To: linux-kernel@...r.kernel.org
Cc: linux-serial@...r.kernel.org, gregkh@...uxfoundation.org,
jirislaby@...nel.org, kgugala@...micro.com, mholenko@...micro.com,
joel@....id.au, david.abdurachmanov@...il.com,
florent@...oy-digital.fr, geert@...ux-m68k.org,
ilpo.jarvinen@...ux.intel.com
Subject: [PATCH v6 07/14] serial: liteuart: rx loop should only ack rx events
While receiving characters, it is necessary to acknowledge each one
by writing to the EV_PENDING register's EV_RX bit. Ensure we do not
also gratuitously set the EV_TX bit in the process.
Signed-off-by: Gabriel Somlo <gsomlo@...il.com>
---
drivers/tty/serial/liteuart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
index 81a86c5eb393..c90ab65fbdcf 100644
--- a/drivers/tty/serial/liteuart.c
+++ b/drivers/tty/serial/liteuart.c
@@ -82,7 +82,7 @@ static void liteuart_timer(struct timer_list *t)
port->icount.rx++;
/* necessary for RXEMPTY to refresh its value */
- litex_write8(membase + OFF_EV_PENDING, EV_TX | EV_RX);
+ litex_write8(membase + OFF_EV_PENDING, EV_RX);
/* no overflow bits in status */
if (!(uart_handle_sysrq_char(port, ch)))
--
2.38.1
Powered by blists - more mailing lists