[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <TYWPR01MB9420832555EFC60126BE0909920F9@TYWPR01MB9420.jpnprd01.prod.outlook.com>
Date: Thu, 24 Nov 2022 01:22:28 +0000
From: <nobuhiro1.iwamatsu@...hiba.co.jp>
To: <xiujianfeng@...wei.com>, <mturquette@...libre.com>,
<sboyd@...nel.org>
CC: <linux-clk@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] clk: visconti: Fix memory leak in visconti_register_pll()
Hi Xiu,
Thanks for your patch!
> -----Original Message-----
> From: Xiu Jianfeng <xiujianfeng@...wei.com>
> Sent: Wednesday, November 23, 2022 12:24 AM
> To: mturquette@...libre.com; sboyd@...nel.org; iwamatsu nobuhiro(岩松 信
> 洋 □SWC◯ACT) <nobuhiro1.iwamatsu@...hiba.co.jp>
> Cc: linux-clk@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org
> Subject: [PATCH] clk: visconti: Fix memory leak in visconti_register_pll()
>
> @pll->rate_table has allocated memory by kmemdup(), if clk_hw_register()
> fails, it should be freed, otherwise it will cause memory leak issue, this patch
> fixes it.
>
> Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and
> reset driver")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
Best regards,
Nobuhiro
> ---
> drivers/clk/visconti/pll.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/visconti/pll.c b/drivers/clk/visconti/pll.c index
> a484cb945d67..1f3234f22667 100644
> --- a/drivers/clk/visconti/pll.c
> +++ b/drivers/clk/visconti/pll.c
> @@ -277,6 +277,7 @@ static struct clk_hw *visconti_register_pll(struct
> visconti_pll_provider *ctx,
> ret = clk_hw_register(NULL, &pll->hw);
> if (ret) {
> pr_err("failed to register pll clock %s : %d\n", name, ret);
> + kfree(pll->rate_table);
> kfree(pll);
> pll_hw_clk = ERR_PTR(ret);
> }
> --
> 2.17.1
Powered by blists - more mailing lists