linux-kernel - Re: [PATCH] iio: addac: ad74413r: fix blank line after declaration warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Nov 2022 19:24:53 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cosmin Tanislav <demonsingur@...il.com>
Cc:     Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: addac: ad74413r: fix blank line after declaration
 warning

On Thu, 24 Nov 2022 17:30:49 +0200
Cosmin Tanislav <demonsingur@...il.com> wrote:

> Checkpatch wants a blank line after all declarations. Add it now,
> even though the patch has already been submitted.
> 
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@...log.com>
> Fixes: 7b2366008125 ("iio: addac: ad74413r: add spi_device_id table")
Dropped fixes tag as this is just cosmetic.

Applied.
> ---
>  drivers/iio/addac/ad74413r.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
> index 61030053cbea..f32c8c2fb26d 100644
> --- a/drivers/iio/addac/ad74413r.c
> +++ b/drivers/iio/addac/ad74413r.c
> @@ -1315,6 +1315,7 @@ static int ad74413r_probe(struct spi_device *spi)
>  	st->chip_info = device_get_match_data(&spi->dev);
>  	if (!st->chip_info) {
>  		const struct spi_device_id *id = spi_get_device_id(spi);
> +
>  		if (id)
>  			st->chip_info =
>  				(struct ad74413r_chip_info *)id->driver_data;