linux-kernel - Re: [PATCH] mm/thp: Rename pmd_to_page() as pmd_pgtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20221124134657.0120000e174fa1a9ad292113@linux-foundation.org>
Date:   Thu, 24 Nov 2022 13:46:57 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/thp: Rename pmd_to_page() as pmd_pgtable_page()

On Thu, 24 Nov 2022 18:46:41 +0530 Anshuman Khandual <anshuman.khandual@....com> wrote:

> Current pmd_to_page(), which derives the page table page containing the pmd
> address has a very misleading name. The problem being, it sounds similar to
> pmd_page() which derives page embedded in a given pmd entry either for next
> level page or a mapped huge page. Rename it as pmd_pgtable_page() instead.
> 

Is the new name much clearer?

There are a zillion of these little conversion functions in the pagemap
layer, all quite confusing yet we seem to have decided that they are so
plainly obvious that no code commenting is needed.  Sigh.