linux-kernel - Re: [PATCH] mm/vmalloc: Add check for KMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20221123202537.3378bf960c01f9773f6a4675@linux-foundation.org>
Date:   Wed, 23 Nov 2022 20:25:37 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmalloc: Add check for KMEM_CACHE

On Thu, 24 Nov 2022 12:02:26 +0800 Jiasheng Jiang <jiasheng@...as.ac.cn> wrote:

> As KMEM_CACHE may return NULL pointer, it should
> be better to check the return value in order to
> avoid NULL pointer dereference in kmem_cache_zalloc.
> 
> ...
>
> @@ -2426,15 +2426,17 @@ void __init vmalloc_init(void)

Linux assumes that allocation attempts from __init code will succeed.

Because if they fail so early in the boot process, the system is so
utterly messed up that we may as well just go oops.